chore!: migrate AnalyticsData to new surface #7941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
| $request = (new CreateAudienceListRequest()) | ||
| ->setParent($formattedParent) | ||
| ->setAudienceList($audienceList); | ||
| $request = (new CreateAudienceListRequest())->setParent($formattedParent)->setAudienceList($audienceList); |
There was a problem hiding this comment.
Nit:
I like the new line versions more for each method than inline.
Hectorhammett
approved these changes
Jan 6, 2025
|
Will the documentation and example code be updated in regards to the changes? |
|
@carestad thanks for pointing this out! Looks like we forgot to update it. You'll see that atleast [the rest of the reference documentation](https://cloud.google.com/php/docs/reference/analytics-admin/latest/V1beta.Client.AnalyticsAdminServiceClient is up to date! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropping previous surface clients
BREAKING_CHANGE_REASON=non-GA libraries can have breaking changes